Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Logs API design doc #6206

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 23, 2025

There were some changes in the design that should be updated. Most importantly:

@pellared pellared self-assigned this Jan 23, 2025
@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (ae7ac48) to head (316ce1a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6206     +/-   ##
=======================================
- Coverage   82.2%   82.2%   -0.1%     
=======================================
  Files        273     273             
  Lines      23743   23743             
=======================================
- Hits       19538   19535      -3     
- Misses      3856    3859      +3     
  Partials     349     349             

see 2 files with indirect coverage changes

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pellared pellared merged commit a027f11 into open-telemetry:main Jan 27, 2025
31 of 32 checks passed
@MrAlias MrAlias added this to the v1.35.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants