Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opentelemetry-operator): Adding extraEnv #1458

Merged
merged 4 commits into from
Jan 7, 2025
Merged

feat(opentelemetry-operator): Adding extraEnv #1458

merged 4 commits into from
Jan 7, 2025

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented Dec 9, 2024

This PR is adding the possibility to specify extra environment variable definitions that are not simple name/value pairs, for example when valueFrom should be used.

@jtyr jtyr requested review from Allex1 and a team as code owners December 9, 2024 21:31
@dmitryax
Copy link
Member

We use extraEnvs in the other helm charts here. Let's keep it consistent. Also, I think we should deprecate env now

jaronoff97
jaronoff97 reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we should probably deprecate env, can you update the comment for env and recommend moving to extraEnvs?

charts/opentelemetry-operator/Chart.yaml Outdated
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-operator
version: 0.75.0
version: 0.76.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the patch version, not the minor version. Once you've done that, please run make generate-examples CHARTS=opentelemetry-operator

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtyr it looks like there's no patch version bump anymore, can you do that and re-run the make generate when you can please?

@jtyr
Copy link
Contributor Author

jtyr commented Dec 22, 2024

@jaronoff97 Please could you review this PR?

jaronoff97
jaronoff97 reviewed Dec 23, 2024
View reviewed changes
charts/opentelemetry-operator/values.yaml
@@ -104,6 +104,14 @@ manager:
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtyr Minor request, can you please update the docstring here and recommend that people use extraEnvs instead of env please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a short deprecation notice. Please review it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 7, 2025
@jtyr jtyr force-pushed the jtyr-otelop-env branch from 2b04f0b to 0640a37 Compare January 7, 2025 17:09
@jtyr
Copy link
Contributor Author

jtyr commented Jan 7, 2025

@jaronoff97 Please review the latest changes.

@TylerHelmuth TylerHelmuth merged commit ee64f22 into open-telemetry:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Allex1 Allex1 Allex1 approved these changes

@puckpuck puckpuck Awaiting requested review from puckpuck

@dmitryax dmitryax Awaiting requested review from dmitryax

@povilasv povilasv Awaiting requested review from povilasv

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jtyr @dmitryax @Allex1 @jaronoff97 @TylerHelmuth