[jmx-scraper] wildfly refactor assertions #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsunday
approved these changes
Dec 10, 2024
SylvainJuge
commented
Dec 10, 2024
| @@ -46,22 +46,6 @@ protected MetricsVerifier createMetricsVerifier() { | |||
| .hasDataPointsWithAttributes( | |||
| attributeGroup(attribute("state", "dead")), | |||
| attributeGroup(attribute("state", "live")))) | |||
| .add( | |||
There was a problem hiding this comment.
[for reviewer] duplicated test assertion for this metric.
| @@ -63,6 +63,9 @@ public MetricsVerifier disableStrictMode() { | |||
| */ | |||
| @CanIgnoreReturnValue | |||
| public MetricsVerifier add(String metricName, Consumer<MetricAssert> assertion) { | |||
| if (assertions.containsKey(metricName)) { | |||
There was a problem hiding this comment.
[for reviewer] this ensures that we don't have duplicated assertions for the same metric.
| prefix: wildfly.jdbc. | ||
| mapping: | ||
| ActiveCount: | ||
| metric: &metric connection.open | ||
| type: updowncounter |
There was a problem hiding this comment.
[for reviewer] this was actually a mistake made when creating the yaml mapping.
trask
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Migrates Wildfly integration test to use the new assertion framework.
Bonus: fixes a few bugs in the yaml definition and hbase tests that were not covered previously 🎉
Part of #1573