fix typo in trace.proto that says end_time >= start_time #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Dec 28, 2023
| @@ -178,7 +178,7 @@ message Span { | |||
| // is the time when the server's application handler starts running. | |||
| // Value is UNIX Epoch time in nanoseconds since 00:00:00 UTC on 1 January 1970. | |||
| // | |||
| // This field is semantically required and it is expected that end_time >= start_time. | |||
| // This field is semantically required and it is expected that end_time <= start_time. | |||
There was a problem hiding this comment.
I think the current wording is correct.
There was a problem hiding this comment.
Oh duh sorry I misread and got confused because the order is the same in the docstring below 🤦🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.