Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #1197

Closed
wants to merge 1 commit into from
Closed

Main #1197

wants to merge 1 commit into from

Conversation

Victorsesan
Copy link
Contributor

Created a readable constant in 8 files to freeze ranges 100..399 .

Relate to #1172

Created a readable constant in 8 files to freeze ranges 100..399 .

Relate to open-telemetry#1172
@kaylareopelle
Copy link
Contributor

Hi @Victorsesan! See my comment on #1172 for next steps: #1172 (comment)

@Victorsesan
Copy link
Contributor Author

Hi @Victorsesan! See my comment on #1172 for next steps: #1172 (comment)

@kaylareopelle Cool!! thanks a lot for all the heads up you're the best, i will try to sort everything out asap and submit again as requested so you can review i will comment again if I'm stuck especially while following the modifications steps in the contribution guide to the list which are sometimes a hassle for me to understand.

@Victorsesan
Copy link
Contributor Author

Victorsesan commented Oct 25, 2024

@kaylareopelle Sorry for the delay, i had got everything on track except setting up bundle install which was required (screenshot below) I have tried almost every method i can think of to have it up and running , i also had to use a different approach since i couldn't install Bundler as root, but nothing worked for me sadly. Should i download and use it locally or a is there a way we can go about this.
Also checkout this commit message below if it hits the mark on the type of commit we need;

fix: Created a readable constant in 8 files to freeze ranges 100..399 .

Reviewed-by: kaylareopelle
Refs: #1172

Thanks
Screenshot 2024-10-25 230909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants