-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OtlpTracePipeline fixed to no longer set global provider #1812
OtlpTracePipeline fixed to no longer set global provider #1812
Conversation
…xporter-Trace-Pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge once we rename all init_tracer
to init_tracer_provider
. Thanks a lot!
…/github.com/utpilla/opentelemetry-rust into utpilla/Update-OTLP-Exporter-Trace-Pipeline
…/github.com/utpilla/opentelemetry-rust into utpilla/Update-OTLP-Exporter-Trace-Pipeline
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1812 +/- ##
=======================================
+ Coverage 73.6% 73.8% +0.1%
=======================================
Files 122 122
Lines 19515 19503 -12
=======================================
+ Hits 14377 14402 +25
+ Misses 5138 5101 -37 ☔ View full report in Codecov by Sentry. |
Thanks for the review! I have addressed all the comments. |
Towards #1592
Changes
global::set_tracer_provider()
themselves, if they want to set a global meter provider.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes