Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-prometheus]: Prepare 0.17.0 release using opentelemetry 0.24 #1957

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

sbernauer
Copy link
Contributor

@sbernauer sbernauer commented Jul 23, 2024

Fixes #1950

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-prometheus/README.md states

The development of prometheus exporter has halt until the Opentelemetry metrics API and SDK reaches 1.0. Current
implementation is based on Opentelemetry API and SDK 0.23

However, this blocks us from bumping the opentelemetry crate in our applications.
I can totally understand if you don't want to spend effort on the opentelemetry-prometheus crate, so I'm opening this PR on a best-effort basis. I'm not sure if the development halt also applies to dependecy bumps.

Please feel free to close this PR without any big explanation, sorry for the noise in that case!
Even in that case people could use the branch https://github.com/sbernauer/opentelemetry-rust/tree/feat/otel-prom-0.17.0 in case they really really needed a fork

Changed

  • Update opentelemetry dependency version to 0.24
  • Update opentelemetry_sdk dependency version to 0.24
  • Update opentelemetry-semantic-conventions dependency version to 0.16

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@sbernauer sbernauer requested a review from a team July 23, 2024 14:39
Copy link

linux-foundation-easycla bot commented Jul 23, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.9%. Comparing base (2b026d9) to head (e2d00dc).

Files Patch % Lines
opentelemetry-prometheus/src/lib.rs 66.6% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1957     +/-   ##
=======================================
- Coverage   74.9%   74.9%   -0.1%     
=======================================
  Files        122     122             
  Lines      20387   20395      +8     
=======================================
+ Hits       15277   15281      +4     
- Misses      5110    5114      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbernauer sbernauer force-pushed the feat/otel-prom-0.17.0 branch from 72c1c2b to e2d00dc Compare July 24, 2024 05:36
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks fine . I will do a release shortly after.

(Note: The prom exporter status still remains same - it may not work with next version of opentelemetry-sdk, and there won't be any fix possible (like this PR), as most likely the upcoming changes will not support pull based exporting at all.)

@cijothomas cijothomas merged commit 383c7d1 into open-telemetry:main Jul 24, 2024
25 checks passed
@cijothomas
Copy link
Member

https://crates.io/crates/opentelemetry-prometheus/0.17.0 is available

@sbernauer
Copy link
Contributor Author

Awesome, many thanks for the quick review and merge!

@ttys3
Copy link
Contributor

ttys3 commented Jul 29, 2024

the upcoming changes will not support pull based exporting at all.

then, what can we do for exists pull based exporter users?

@cijothomas
Copy link
Member

the upcoming changes will not support pull based exporting at all.

then, what can we do for exists pull based exporter users?

Prom exporter will need to stick with last-working-version :(
(Prometheus now has native support for accepting OTLP, or a OTLP Exporter + Collector to expose metrics - these are alternatives)

Cutting down features is important to get to a stable release sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: opentelemetry-prometheus can not be used with latest opentelemetry
4 participants