-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry-prometheus]: Prepare 0.17.0 release using opentelemetry 0.24 #1957
[opentelemetry-prometheus]: Prepare 0.17.0 release using opentelemetry 0.24 #1957
Conversation
The committers listed above are authorized under a signed CLA. |
1bdc6e0
to
72c1c2b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
=======================================
- Coverage 74.9% 74.9% -0.1%
=======================================
Files 122 122
Lines 20387 20395 +8
=======================================
+ Hits 15277 15281 +4
- Misses 5110 5114 +4 ☔ View full report in Codecov by Sentry. |
72c1c2b
to
e2d00dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks fine . I will do a release shortly after.
(Note: The prom exporter status still remains same - it may not work with next version of opentelemetry-sdk, and there won't be any fix possible (like this PR), as most likely the upcoming changes will not support pull based exporting at all.)
Awesome, many thanks for the quick review and merge! |
then, what can we do for exists pull based exporter users? |
Prom exporter will need to stick with last-working-version :( Cutting down features is important to get to a stable release sooner. |
Fixes #1950
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-prometheus/README.md states
However, this blocks us from bumping the
opentelemetry
crate in our applications.I can totally understand if you don't want to spend effort on the
opentelemetry-prometheus
crate, so I'm opening this PR on a best-effort basis. I'm not sure if the development halt also applies to dependecy bumps.Please feel free to close this PR without any big explanation, sorry for the noise in that case!
Even in that case people could use the branch https://github.com/sbernauer/opentelemetry-rust/tree/feat/otel-prom-0.17.0 in case they really really needed a fork
Changed
opentelemetry
dependency version to 0.24opentelemetry_sdk
dependency version to 0.24opentelemetry-semantic-conventions
dependency version to 0.16Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes