Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo bench on Windows, where pprof is not a accessible crate #2392

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

malkia
Copy link

@malkia malkia commented Dec 7, 2024

Changes

Just synced the project, did cargo bench and found tests not compiling due to unavailable on Windows pprof crate.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@malkia malkia requested a review from a team as a code owner December 7, 2024 01:08
Copy link

linux-foundation-easycla bot commented Dec 7, 2024

CLA Not Signed

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (1a4e931) to head (38ea623).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2392   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        122     122           
  Lines      21511   21511           
=====================================
  Hits       17060   17060           
  Misses      4451    4451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You need to sign the CLA agreement before accepting any contributions. Please click the link and follow through. You may want to consult your employer if you are working on behalf of a company.

@malkia
Copy link
Author

malkia commented Dec 8, 2024

I need to check with my peeps about CLA, but if nothing else I can close this and someone else can do the fixes with CLA - it's only like 2 lines of change

@lalitb lalitb added the S-blocked-cla Status: Issues blocked on CLA label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked-cla Status: Issues blocked on CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants