-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle batch log processing in a dedicated background thread #2436
Handle batch log processing in a dedicated background thread #2436
Conversation
name: "BatchLogProcessor.Shutdown.Timeout", | ||
message = "BatchLogProcessor shutdown timed out." | ||
); | ||
LogError::ExportTimedOut(self.shutdown_timeout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is shutdown timing out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left few comments.
We need to make it similar to #2403, and keep existing batch processor under separate feature flag before merge.
This looks in good shape at first glance. Thanks for the PR. Will like to do one final round of review, and some tests before approval today. Meanwhile we need to -
|
I tested the following OTLP export scenarios with this PR:
I believe this behavior is consistent with what we expect, and observed with the Periodic exporter, which is positive. |
We should be able to add this to the integration test suite easily enough! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2436 +/- ##
=======================================
- Coverage 76.8% 76.1% -0.8%
=======================================
Files 122 122
Lines 21851 22056 +205
=======================================
- Hits 16797 16790 -7
- Misses 5054 5266 +212 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Integration tests are not working, but that is good to be handled in a separate PR.
Left a non blocking comment.
Fixes #2066 . This will replace #2096, with the feedback taken there and ported the change from scratch to avoid merging conflicts.
The replaces
BatchLogProcessor
depending on async runtime will be extracted out to a separated type under feature flag, in case it is still needed in some cases.Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes