-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value_type to feature flag event #1689
base: main
Are you sure you want to change the base?
Conversation
Non-binding approval from me ✔️ |
|
||
--- | ||
|
||
`feature_flag.evaluation.value.type` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not for this PR, but we're seriously considering allowing complex attribute types instead of body
#1669 open-telemetry/opentelemetry-specification#4334.
Wonder what your thoughts are
@dyladan could you please elaborate on
the type information is a part of OTLP (e.g. here's a map attribute json example) {
"key": "map.attribute",
"value": {
"kvlistValue": { # type info
"values": [
{
"key": "some.map.key",
"value": {
"stringValue": "some value" # type info in stringValue
}
}
]
}
} body should be represented in the same way. So I wonder why is it a problem for the pipeline - it should know the type, no? |
This adds a
value_type
which references the body fieldvalue
in feature flag evaluation events. Thevalue
field has an undefined type, allowing any type to be included. This means processing pipelines have to sniff the type before applying any logic. In some cases this may even result in ambiguous cases. For example if a processing pipeline stringifies the value, it may be impossible to tell the difference between booleanfalse
and string"false"
.