Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement any_of and include constraints support #39

Merged
merged 11 commits into from
Feb 28, 2024
Merged

[Feature] Implement any_of and include constraints support #39

merged 11 commits into from
Feb 28, 2024

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Feb 27, 2024

This PR finalizes the resolution process for a semantic convention registry. More specifically, the following resolution steps have been implemented:

  • Resolution of the include constraints: attributes and any_of constraints of the group pointed by the include reference are imported into the group containing the reference.
  • Resolution of the any_of constraints: all any_of constraints are checked.

Some tests have been implemented, however more exhaustive tests will be implemented in the future (see #8).

@lquerel lquerel added the enhancement New feature or request label Feb 27, 2024
@lquerel lquerel self-assigned this Feb 27, 2024
@lquerel lquerel requested a review from jsuereth as a code owner February 27, 2024 02:08
jsuereth
jsuereth reviewed Feb 27, 2024
View reviewed changes
crates/weaver_resolved_schema/src/catalog.rs Outdated Show resolved Hide resolved
crates/weaver_resolver/src/registry.rs Outdated Show resolved Hide resolved
crates/weaver_resolver/src/registry.rs Outdated Show resolved Hide resolved
jsuereth
jsuereth approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I actually expected we'd do the error merging thing as a follow-up PR, but this is better.

crates/weaver_resolver/src/registry.rs Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 28, 2024
View reviewed changes
src/search/mod.rs Fixed Show fixed Hide fixed
src/search/mod.rs Fixed Show fixed Hide fixed
@lquerel lquerel merged commit d92bf65 into open-telemetry:main Feb 28, 2024
14 checks passed
@lquerel lquerel deleted the constraints_support branch March 8, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

Assignees

@lquerel lquerel

Labels
enhancement New feature or request
Projects
OTel Weaver Project
Status: Done
Milestone
Semantic Convention Registry Focus
Development

Successfully merging this pull request may close these issues.
2 participants
@lquerel @jsuereth