-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update acronym filter to ignore word boundaries. #480
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
+ Coverage 73.9% 74.0% +0.1%
=======================================
Files 50 50
Lines 3903 3938 +35
=======================================
+ Hits 2885 2917 +32
- Misses 1018 1021 +3 ☔ View full report in Codecov by Sentry. |
Thinking back about this problem, I believe this approach is problematic. For example, let's imagine these two metrics:
If we apply these filters
Which is probably not what we want either. I'm thinking about these two approaches:
There might be other simpler approaches. |
I see two options here:
|
I’m not sure which one will be the easiest to implement. I think I would start by checking if there is a hook mechanism in the library used for casing, and if there isn’t, I would probably try to address the issue in the acronym filter. |
Fixes #415