Add a to_yaml filter #525
Open
Add a to_yaml filter #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerbly
requested changes
Dec 15, 2024
Comment on lines
+136
to
+137
| let value = serde_json::to_value(value) | ||
| .map_err(|error| minijinja::Error::new(ErrorKind::BadSerialization, error.to_string()))?; |
There was a problem hiding this comment.
This is unnecessary, you can pass a reference to minijinja::Value directly to serde_yaml::to_string because it implements serde::Serialize.
| .map_err(|error| minijinja::Error::new(ErrorKind::BadSerialization, error.to_string()))?; | ||
|
|
||
| let yaml = serde_yaml::to_string(&value) | ||
| .map_err(|error| minijinja::Error::new(ErrorKind::BadSerialization, error.to_string()))?; |
There was a problem hiding this comment.
Perhaps there's a way to write a test to exercise the error condition?
lquerel
requested changes
Dec 16, 2024
| @@ -131,6 +132,16 @@ pub fn acronym(acronyms: Vec<String>) -> impl Fn(&str) -> String { | |||
| } | |||
| } | |||
|
|
|||
| fn to_yaml(value: Value) -> Result<String, minijinja::Error> { | |||
There was a problem hiding this comment.
You should take the tojson filter implemented in the standard minijinja library as an example. The method’s signature is slightly different, and more importantly, they address the compatibility of the output with HTML (pay attention to the last map function). We don’t need the pretty-printing part since YAML is always pretty-printed and we probably don't need the indent parameter too.
See the permalink below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need
People have expressed a need to dump a value into yaml file. #423
Solution
WIP: This pull request adds a
to_yamlfilter that can be used to dump a value into a YAML file.Known limitation
The implementation does not currently maintain ordering