Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--readme flag #93

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

--readme flag #93

wants to merge 1 commit into from

Conversation

bennypowers
Copy link
Member

What I Did

  1. add --readme flag along with --header, --footer, and --headingOffset to analyzer.
  • adds cem-plugin-readme as a dep to analyzer
  • the code for readme is lazy loaded only if the user provides the --readme flag, otherwise it's not imported

Alternative approaches considered:

  • scan node_modules for cem plugins, kind of like how karma does it, and have those plugins export their own command line definitions
    • PRO: doesn't pollute analyzer with deps and extra code
    • CON: scanning node_modules is kind of gross? is there another way to do that?

Depends on #87

@netlify
Copy link

netlify bot commented Jul 11, 2021

❌ Deploy Preview for custom-elements-manifest-analyzer failed.

🔨 Explore the source changes: d56b40b

🔍 Inspect the deploy log: https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/60eaf923145f200008421653

@bennypowers bennypowers marked this pull request as draft July 11, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant