Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Remove Session, SessionEvent classes #22

Closed
berka3 opened this issue Nov 23, 2023 · 0 comments · Fixed by #23
Closed

Refactoring: Remove Session, SessionEvent classes #22

berka3 opened this issue Nov 23, 2023 · 0 comments · Fixed by #23
Assignees
@berka3

Comments

@berka3
Copy link
Contributor

berka3 commented Nov 23, 2023 •
edited
Loading

  • use common classes (ApiEvent, Event) for all types of events
  • new generic functions decodeEvent (encodeEvent) for all types of events (inline fun <reified T : Event> decodeEvent(text: String): ApiEvent<T>)
@berka3 berka3 changed the title Refactoring: RemoveSession, SessionEvent classes Refactoring: Remove Session, SessionEvent classes Nov 23, 2023
@berka3 berka3 self-assigned this Nov 23, 2023
berka3 added a commit that referenced this issue Nov 27, 2023
@berka3
refactor: remove Session, SessionEvent and restructure test package
9de6d08 
Closes #22
berka3 added a commit that referenced this issue Nov 27, 2023
@berka3
refactor: remove Session, SessionEvent and restructure test package
71423fc 
Closes #22
berka3 added a commit that referenced this issue Nov 28, 2023
@berka3
refactor: remove Session, SessionEvent and restructure test package
4ac9b4d 
Closes #22
@berka3 berka3 linked a pull request Nov 28, 2023 that will close this issue
refactoring: refactor Session, SessionEvent #23
Merged
berka3 added a commit that referenced this issue Nov 28, 2023
@berka3
refactor: remove Session, SessionEvent and restructure test package
9402d07 
Closes #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berka3 berka3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactoring: refactor Session, SessionEvent open200/xesar-connect
1 participant
@berka3