refactoring: refactor Session, SessionEvent #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
berka3
commented
Nov 28, 2023
berka3
commented
- Replace the usage of the old classes (Session, SessionEvent) with the newly introduced ApiEvent and Event classes
- add new generic functions encodeEvent and decodeEvent for all types of events
berka3
force-pushed
the
22-refactoring-remove-session-sessionevent-classes
branch
from
4ac9b4d to
9402d07
Compare
andreasgrill
approved these changes
Nov 29, 2023
berka3
deleted the
22-refactoring-remove-session-sessionevent-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.