Skip to content

Commit

Permalink
More lint improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
ingalls committed Sep 29, 2021
1 parent 6fde63c commit ad96484
Show file tree
Hide file tree
Showing 23 changed files with 7,636 additions and 5,042 deletions.
8 changes: 4 additions & 4 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"presets": ["@babel/env"],
"plugins": [
"@babel/plugin-syntax-class-properties"
]
"presets": ["@babel/env"],
"plugins": [
"@babel/plugin-syntax-class-properties"
]
}

1 change: 1 addition & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"extends": "eslint:recommended",
"root": true,
"parser": "@babel/eslint-parser",
"parserOptions": {
"ecmaVersion": 2018,
Expand Down
8 changes: 4 additions & 4 deletions api/.babelrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"presets": ["@babel/env"],
"plugins": [
"@babel/plugin-syntax-class-properties"
]
"presets": ["@babel/env"],
"plugins": [
"@babel/plugin-syntax-class-properties"
]
}

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
"lint": "eslint cloudformation/**.js"
},
"dependencies": {
"@babel/eslint-parser": "^7.15.7",
"@babel/eslint-plugin": "^7.14.5",
"@babel/plugin-syntax-class-properties": "^7.12.13",
"@babel/preset-env": "^7.15.6",
"@mapbox/cloudfriend": "^5.0.1",
"aws-sdk": "^2.901.0",
"batch-alarms": "2.0.0",
Expand All @@ -25,6 +21,10 @@
},
"devDependencies": {
"eslint": "^7.25.0",
"eslint-plugin-node": "^11.0.0"
"eslint-plugin-node": "^11.0.0",
"@babel/eslint-parser": "^7.15.7",
"@babel/eslint-plugin": "^7.14.5",
"@babel/plugin-syntax-class-properties": "^7.12.13",
"@babel/preset-env": "^7.15.6"
}
}
7 changes: 7 additions & 0 deletions task/.babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"presets": ["@babel/env"],
"plugins": [
"@babel/plugin-syntax-class-properties"
]
}

53 changes: 53 additions & 0 deletions task/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{
"extends": "eslint:recommended",
"root": true,
"parser": "@babel/eslint-parser",
"parserOptions": {
"ecmaVersion": 2018,
"babelOptions": {
"configFile": "./.babelrc"
}
},
"env": {
"node": true,
"es6": true
},
"plugins": [ "node", "@babel" ],
"rules": {
"no-console": 0,
"arrow-parens": [ "error", "always" ],
"no-var": "error",
"prefer-const": "error",
"array-bracket-spacing": [ "error", "never" ],
"comma-dangle": [ "error", "never" ],
"computed-property-spacing": [ "error", "never" ],
"eol-last": "error",
"eqeqeq": [ "error", "smart" ],
"indent": [ "error", 4, { "SwitchCase": 1 } ],
"no-confusing-arrow": [ "error", { "allowParens": false } ],
"no-extend-native": "error",
"no-mixed-spaces-and-tabs": "error",
"func-call-spacing": [ "error", "never" ],
"no-trailing-spaces": "error",
"no-unused-vars": "error",
"no-use-before-define": [ "error", "nofunc" ],
"object-curly-spacing": [ "error", "always" ],
"prefer-arrow-callback": "error",
"quotes": [ "error", "single", "avoid-escape" ],
"semi": [ "error", "always" ],
"space-infix-ops": "error",
"spaced-comment": [ "error", "always" ],
"keyword-spacing": [ "error", { "before": true, "after": true } ],
"template-curly-spacing": [ "error", "never" ],
"semi-spacing": "error",
"strict": "error",
"node/no-unsupported-features": [ "error", { "version": 8 } ],
"node/no-missing-require": "error",
"valid-jsdoc": ["warn", {
"requireParamDescription": false,
"requireReturnDescription": false,
"requireReturnType": false,
"requireReturn": false
}]
}
}
2 changes: 1 addition & 1 deletion task/collect.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env node

'use strict';


// Does not need to mark instance
// as protected as it runs on a managed queue
Expand Down
2 changes: 1 addition & 1 deletion task/export.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env node

'use strict';


require('./lib/pre');

Expand Down
2 changes: 1 addition & 1 deletion task/fabric.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env node

'use strict';


// Does not need to mark instance
// as protected as it runs on a managed queue
Expand Down
2 changes: 1 addition & 1 deletion task/lib/job.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';


const Ajv = require('ajv');
const wkt = require('wellknown');
Expand Down
2 changes: 1 addition & 1 deletion task/lib/meta.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';


const AWS = require('aws-sdk');

Expand Down
2 changes: 1 addition & 1 deletion task/lib/pre.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';


if (!process.env.AWS_DEFAULT_REGION) {
process.env.AWS_DEFAULT_REGION = 'us-east-1';
Expand Down
2 changes: 1 addition & 1 deletion task/lib/stats.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';


const fs = require('fs');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion task/lib/tippecanoe.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';


const CP = require('child_process');
const stream = require('stream');
Expand Down
2 changes: 1 addition & 1 deletion task/lib/validator.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';


/**
* @class Validator
Expand Down
Loading

0 comments on commit ad96484

Please sign in to comment.