feat(spindle-tokens): add 3rd party colors #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasaplus1
requested review from
a team,
herablog,
tokimari and
tatz012
and removed request for
ameba-spindle and
a team
|
ありがとうございます！結論からいうと・・どちらも追加お願いしたいです！ また、将来的(いつなの？)に自動化を考えてまして、命名以下PRを踏襲いただけるとありがたいでっす！ |
|
おお、自動化楽しみです。では足りていない変数を追加します。 |
sasaplus1
changed the title
herablog
reviewed
Apr 16, 2024
| --color-third-party-youtube-red: var(--youtube-red); | ||
| --color-third-party-amazon-yellow: var(--amazon-yellow); | ||
| --color-third-party-amazon-black: var(--amazon-black); | ||
| --color-third-party-rakuten-red: var(--rakuten-red); |
There was a problem hiding this comment.
ここは Figma の定義だと Rakuten になってそうですね 🤔
There was a problem hiding this comment.
おや、色名がつくのだと思ってました。修正します。
There was a problem hiding this comment.
figmaにあるThird Partyの色見本表（？）へのリンクを以前渡されたのですが、そこでは上にRakutenと書いてあり下に薄い字でRakuten Redとあるんですが上に書いてある方が変数名になるということですかね？
There was a problem hiding this comment.
おそらく上がテーマカラーで下がプリミティブカラーなのですが、Figmaのファイルに見た目として表示されているTextとFigma内にデータとして登録されているstringが違うことあるんですよね・・なので確認してみます。
There was a problem hiding this comment.
協議の結果 (?) light/dark テーマ対応で、diffが結構変わりました 😅
herablog
reviewed
Apr 16, 2024
| --color-third-party-amazon-yellow: var(--amazon-yellow); | ||
| --color-third-party-amazon-black: var(--amazon-black); | ||
| --color-third-party-rakuten-red: var(--rakuten-red); | ||
| --color-third-party-yahoo-red: var(--yahoo-red); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
サードパーティカラーを追加しました。
--color-third-party-のプレフィックスがついた変数は追加しなかったのですがこちらのプレフィックスがついた変数がすべて存在するわけではないことにはどういった理由があるんでしょうか。