Do NOT use eval that does NOT return the exit code of the command... …

…CI should fail
opencollab · Sep 15, 2024 · d2dba84 · d2dba84
1 parent ae5ecf6
commit d2dba84
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/EXAMPLES/MATRIX_MARKET/arpackmm.sh b/EXAMPLES/MATRIX_MARKET/arpackmm.sh
@@ -65,17 +65,17 @@ do
                     fi
 
                     # Run arpackmm: use --nbCV 6 and --maxIt 200 to ease convergence.
-                    export CMD="./arpackmm $eigPb $genPb $magOpt $shiftRI $invert $tol $slv $rs $dsPrec $dsMat $extraGenPb --nbCV 6 --maxIt 200 --verbose 3 --debug 3"
-                    echo "$CMD"
-                    eval "$CMD &> arpackmm.run.log"
-                    export CMDLOG="tail arpackmm.run.log"
-                    eval "$CMDLOG"
+                    ./arpackmm $eigPb $genPb $magOpt $shiftRI $invert $tol $slv $rs $dsPrec $dsMat $extraGenPb \
+                               --nbCV 6 --maxIt 200                                                            \
+                               --verbose 3 --debug 3 &> arpackmm.run.log
+                    tail arpackmm.run.log
 
                     # Run arpackmm: re-run with restart from slightly different starting point using shift.
-                    export CMD="$CMD --restart --shiftReal 0.5"
-                    echo "$CMD"
-                    eval "$CMD &> arpackmm.run.log"
-                    eval "$CMDLOG"
+                    ./arpackmm $eigPb $genPb $magOpt $shiftRI $invert $tol $slv $rs $dsPrec $dsMat $extraGenPb \
+                               --nbCV 6 --maxIt 200                                                            \
+                               --restart --shiftReal 0.5                                                       \
+                               --verbose 3 --debug 3 &> arpackmm.run.log
+                    tail arpackmm.run.log
                     echo "========================================================================================"
                     echo ""
                   done