zos updates #1273
Open
zos updates #1273
+237
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Johnson <[email protected]> Signed-off-by: Kershaw Mehta <[email protected]>
kershawmehta
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
|
Only glancing over; would it be clearer to move the removal of devices to a separate commit? Currently it made me almost consider that "namespaces" was a replacement for devices which was a bit confusing. |
|
Or is it a replacement? 🙈 |
AkihiroSuda
reviewed
Dec 30, 2024
AkihiroSuda
reviewed
Jan 8, 2025
| @@ -0,0 +1,138 @@ | |||
| { | |||
| "ociVersion": "0.5.0-dev", | |||
There was a problem hiding this comment.
The ociVersion is the same as used in spec-example.json.
AkihiroSuda
approved these changes
Jan 8, 2025
Signed-off-by: Kershaw Mehta <[email protected]>
The deletion of devices and the addition of namespaces are unrelated. However, I thought that having these in a single PR would be more efficient, given this is the resultant of what is supported by z/OS Container Platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes updates to the OCI runtime spec with z/OS platform-specific details, including adding namespaces, adding noNewPrivileges flag, and removing devices. These changes are currently in use by the IBM z/OS Container Platform (zOSCP) product - details can be found here: https://www.ibm.com/products/zos-container-platform.
Note: The "removing of devices" is not considered to be an incompatible change since no user would have been using the z/OS-specific portion of the runtime spec, prior to the initial zOSCP release.