Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding fix for matchLOGOS with python test. #3594

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Nov 17, 2023

Fixes #3589

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor Author

 ======================================================================
ERROR: test_basic (test_descriptors.matchLOGOS_test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ci/opencv_contrib/modules/xfeatures2d/misc/python/test/test_descriptors.py", line 31, in test_basic
    matches1to2 = cv.matchLOGOS(keypoints1, keypoints2, range(len(keypoints1)), range(len(keypoints2)))
AttributeError: module 'cv2' has no attribute 'matchLOGOS'

----------------------------------------------------------------------

@asmorkalov asmorkalov force-pushed the as/matchLOGOS_bindining_fix branch from 18c68e5 to daded36 Compare December 15, 2023 16:02
@asmorkalov asmorkalov merged commit ab4bfc2 into opencv:4.x Dec 15, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matchLOGOS not working with Python
1 participant