fix aruco tests #3695
Merged
fix aruco tests #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ | |||
| namespace opencv_test { namespace { | |||
|
|
|||
|
|
|||
| TEST(CV_ArucoTutorial, can_find_singlemarkersoriginal) | |||
| TEST(DISABLED_CV_ArucoTutorial, can_find_singlemarkersoriginal) | |||
| { | |||
| string img_path = cvtest::findDataFile("aruco/singlemarkersoriginal.jpg", false); | |||
There was a problem hiding this comment.
No need to disable, need to use testing API properly.
These files are part of opencv_extra. They can't be "optional" as specified by the second parameter. "optional" is used for files from downloaded shared drive (e.g. DL models).
false should be removed (removed not replaced).
AleksandrPanov
force-pushed
the
disabled_aruco_tutorial_tests
branch
from
b7a86b3 to
b9a9931
Compare
opencv-alalek
changed the title
opencv-alalek
approved these changes
Mar 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the tests are failing, e.g. https://pullrequest.opencv.org/buildbot/builders/precommit-contrib_linux64/builds/101043/steps/test_aruco/logs/tests%20summary
relates #3401