-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: Two simple fixes to We Chat QR Code module #3698
4.x: Two simple fixes to We Chat QR Code module #3698
Conversation
- decodemgr.cpp: fix messed: width <--> height - unicomblock.cpp: fix wrong type at sizeof(...)
Dear reviewers! CI failes at opencv_perf_wechat_qrcode test at 2_qrcodes.png image, However, I think this regression is not caused by this pull-request. 🤔 What if we fix/update this test: try another picture with 2 QR codes, easier
|
This image is excluded from accuracy test: opencv_contrib/modules/wechat_qrcode/test/test_qrcode.cpp Lines 44 to 46 in bf95e79
I suggest excluding it from perf test too. |
as this image appears too difficult, so that test fails on it
@mshabunin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Two simple fixes to We Char QR Code module:
- decodemgr.cpp: fix messed: width <--> height
- unicomblock.cpp: fix wrong type at
sizeof(...)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.