Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Two simple fixes to We Chat QR Code module #3698

Merged
merged 2 commits into from
Mar 20, 2024
Merged

4.x: Two simple fixes to We Chat QR Code module #3698

merged 2 commits into from
Mar 20, 2024

Conversation

elatkin
Copy link

@elatkin elatkin commented Mar 15, 2024

Two simple fixes to We Char QR Code module:
- decodemgr.cpp: fix messed: width <--> height
- unicomblock.cpp: fix wrong type at sizeof(...)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
allow_multiple_commits=1

- decodemgr.cpp: fix messed: width <--> height
- unicomblock.cpp: fix wrong type at sizeof(...)
@elatkin
Copy link
Author

elatkin commented Mar 18, 2024

Dear reviewers!

CI failes at opencv_perf_wechat_qrcode test at 2_qrcodes.png image,
like this log (as I can reproduce this failure at my local machine):

However, I think this regression is not caused by this pull-request. 🤔
Algorithm appears too sensitive; this test case may pass or fail by occasion,
as such test image may be too difficult for decoding with this algorithm.

What if we fix/update this test: try another picture with 2 QR codes, easier
for decoding, which my fixed variant of algorithm would be able to process?
Specifically, I propose simpler picture with my pull-request to opencv_extra:

  • PR #1156 fix opencv_perf_wechat_qrcode failure by simplifying test image

@mshabunin
Copy link
Contributor

This image is excluded from accuracy test:

std::string qrcode_images_multiple[] = {/*"2_qrcodes.png",*/ "3_close_qrcodes.png", /*"3_qrcodes.png",
"4_qrcodes.png", "5_qrcodes.png", "6_qrcodes.png",*/
"7_qrcodes.png"/*, "8_close_qrcodes.png"*/};

I suggest excluding it from perf test too.

as this image appears too difficult, so that test fails on it
@elatkin
Copy link
Author

elatkin commented Mar 19, 2024

@mshabunin
Could you please review once again? I have added new commit to exclude 2_qrcodes.png, like you propose.

@elatkin elatkin changed the title 4.x: Two simple fixes to We Char QR Code module 4.x: Two simple fixes to We Chat QR Code module Mar 19, 2024
Copy link
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@opencv-pushbot opencv-pushbot merged commit b42682b into opencv:4.x Mar 20, 2024
10 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants