Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Fix data corruption in WeChatQRCode::impl::decode #3701

Conversation

elatkin
Copy link

@elatkin elatkin commented Mar 20, 2024

Data corruption may lead to incorrect results if multiple QR found at image

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
allow_multiple_commits=1

(it may lead to incorrect results if multiple QR found at image)
@mshabunin
Copy link
Contributor

Is it possible to add simple test case reproducing the issue? E.g. with some synthetic image or one of existing test images?

@mshabunin
Copy link
Contributor

I suggest also changing method signature to use const vector<Mat>& candidate_points and for-loop to use const auto& point for consistency.

@elatkin elatkin changed the title Fix data corruption in WeChatQRCode::impl::decode 4.x: Fix data corruption in WeChatQRCode::impl::decode Mar 21, 2024
@opencv-pushbot opencv-pushbot merged commit 9373b72 into opencv:4.x Mar 22, 2024
10 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants