C-API cleanup: highgui, videoio #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Sep 9, 2024
❗ Potential conflicts with #25958 C-API cleanup: highgui, videoio #26025 ❗ Merge with: opencv/opencv_contrib#3780 This PR removes usage of C-API from highgui and videoio modules. Only source code is affected, tests were not using obsolete API. It should be possible to backport these changes to 4.x branch preserving removed public headers and source files (`*_c.h` and `*_c.cpp`). #### Checklist I tried to verify as many backends as possible, though these checks were not as thorough as I'd like them to be. Below is the checklist covering all modified backends with their statuses. > 🔹 - small changes > 🟢 - consider working > ⚪ - considered untested ##### highgui Pass | Backend | Local check | CI check -----|---------|-------------|--------- 🟢 | GTK2 | build + test, plugin build | build + test ❔ 🟢 | GTK3 | build + test, plugin build | build + test 🟢 | QT | build + test, plugin build | ⚪ | Wayland 🔹 | | 🟢 | WIN32 🔹 | | build + test 🟢 | Cocoa 🔹 | | build + test ⚪ | WinRT | | ##### videoio Pass | Backend | Local check | CI check -----|---------|-------------|--------- 🟢 | Android Camera/MediaNDK 🔹 | | build 🟢 | Aravis | build | 🟢 | AVFoundation OSX | | build + test ⚪ | AVFoundation iOS | | build 🟢 | DC1394 | build | 🟢 | DShow 🔹 | | build 🟢 | FFMpeg | build, plugin build | build + test 🟢 | GPhoto 🔹 | build | 🟢 | GStreamer | build, plugin build | build + test 🟢 | Images | build | build + test 🟢 | MSMF 🔹 | | build + test 🟢 | OpenNI | build | 🟢 | PVAPI | build | 🟢 | V4L | build + test | build 🟢 | XIMEA | build | 🟢 | XINE 🔹 | build | #### Notes - local linux build checks performed using [this framework](https://github.com/mshabunin/opencv-videoio-build-check) - minor extra changes made in both `cap_avfoundation*.mm` to make them slightly more synchronized - it would be better to combine them into a single one in the future - configurations with plugins have been build but not tested - **moved unrelated changes to separate PRs** ~two issues have been fixed in separate commits:~ - ~imgproc: missing `cv::hal::` color conversion functions has been used in MediaSDK backend~ - ~videoio/V4L: wrong color conversion mode caused bad colors for NV12 camera input format (RGB instead of BGR)~ It would be nice to check following functionality manually: - [ ] OSX: camera input - [ ] iOS: camera and file input - [ ] WinRT: build, some testing - [x] Linux/Wayland: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opencv/opencv#26025