Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDefaultName() added #3829

Merged
merged 2 commits into from
Nov 26, 2024
Merged

getDefaultName() added #3829

merged 2 commits into from
Nov 26, 2024

Conversation

abbaselmas
Copy link
Contributor

all other contrib feature has this function but tbmr

@abbaselmas
getDefaultName() added
8f69a81 
all other contrib feature has this function but tbmr
@sturkmen72
Copy link
Contributor

@abbaselmas missing CV_WRAP String getDefaultName() const CV_OVERRIDE; at https://github.com/abbaselmas/opencv_contrib/blob/patch-1/modules/xfeatures2d/include/opencv2/xfeatures2d.hpp#L1196-L1212

@abbaselmas
Update xfeatures2d.hpp
0130d80 
missing CV_WRAP String getDefaultName() const CV_OVERRIDE; at
@abbaselmas
Copy link
Contributor Author

missing CV_WRAP String getDefaultName() const CV_OVERRIDE; at

@sturkmen72 good catch thanks for the heads up

@asmorkalov asmorkalov self-assigned this Nov 26, 2024
@asmorkalov asmorkalov merged commit ec5e4c3 into opencv:4.x Nov 26, 2024
9 of 11 checks passed
@abbaselmas abbaselmas deleted the patch-1 branch November 28, 2024 05:52
@asmorkalov asmorkalov mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
category: xfeatures2d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abbaselmas @sturkmen72 @asmorkalov