Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Commit

Permalink
docs: Update pull request template.
Browse files Browse the repository at this point in the history
  • Loading branch information
adzuci authored and Adam Blackwell committed Jan 10, 2024
1 parent d04674b commit 5efb3b6
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@ Configuration Pull Request

Make sure that the following steps are done before merging:

- [ ] A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
- [ ] Are you adding any new default values that need to be overridden when this change goes live? If so:
- [ ] Update the appropriate internal repo (be sure to update for all our environments)
- [ ] If you are updating a secure value rather than an internal one, file a SRE ticket with details.
- [ ] Add an entry to the CHANGELOG.
- [ ] If you are making a complicated change, have you performed the proper testing specified on the [Ops Ansible Testing Checklist](https://openedx.atlassian.net/wiki/spaces/SRE/pages/28967861/Ops+Ansible+Testing+Checklist)? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
- [ ] Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?
- [ ] Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
- [ ] If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
- [ ] Performed the appropriate testing.
- [ ] Think about how this change will affect Open edX operators and update the wiki page for the next Open edX release if needed

0 comments on commit 5efb3b6

Please sign in to comment.