feat!: Legacy account, profile, order history removal #36219
Conversation
**DRAFT** This work is in progress, tests are failing, in no way is this ready to go. FIXES: APER-3884
This removes the legacy account and profile applications, and the order history page. This is primarily a reapplication of #31893, which was rolled back due to prior blockers. FIXES: APER-3884 FIXES: openedx/public-engineering#71 --------- Co-authored-by: Bilal Qamar <[email protected]>
…ile-legacy-django-apps
it looks like prior attempts to reformat the files moved pylint directives to the wrong lines.
| ALLOWED_HOSTS = [ | ||
| '*' | ||
| ] | ||
| ALLOWED_HOSTS = ["*"] |
There was a problem hiding this comment.
Aargh, I didn't mean to let my IDE reformat this file to our current standards. I mean, it's not wrong, but it makes life harder for the reviewers. Sorry. 😬 I think it's just this file, though.
| # .. toggle_target_removal_date: 2020-12-31 | ||
| # .. toggle_warning: Also set settings.PROFILE_MICROFRONTEND_URL and site's ENABLE_PROFILE_MICROFRONTEND. | ||
| # .. toggle_tickets: DEPR-17 | ||
| REDIRECT_TO_PROFILE_MICROFRONTEND = WaffleFlag(f'{WAFFLE_FLAG_NAMESPACE}.redirect_to_microfrontend', __name__) |
There was a problem hiding this comment.
Do we need to add any additional internal tickets to clean up the config for this flag in the LMS?
edit: (and the other flags removed in this PR)
| @@ -385,6 +385,7 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing | |||
| ############## Settings for Microfrontends ######################### | |||
| LEARNING_MICROFRONTEND_URL = 'http://localhost:2000' | |||
| ACCOUNT_MICROFRONTEND_URL = 'http://localhost:1997' | |||
| PROFILE_MICROFRONTEND_URL = 'http://localhost:1995' | |||
There was a problem hiding this comment.
2U specific -- I think we want to add this change to https://github.com/edx/devstack/blob/master/py_configuration_files/lms.py
There was a problem hiding this comment.
I will make that PR, thanks. I knew there was a reason I asked you to be the reviewer 😆
deborahgu
deleted the
dkaplan1/APER-3884_remove-account-and-profile-legacy-django-apps
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
This removes the legacy account and profile applications, and the order history page. This is primarily a reapplication of #31893, which was rolled back due to prior blockers in an external repository, now resolved.
FIXES: APER-3884
FIXES: openedx/public-engineering#71
Co-authored-by: Bilal Qamar [email protected]
Co-authored-by: Muhammad Abdullah Waheed [email protected]