Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add patch endpoint to update transcript providers #562

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

BrandonHBodine
Copy link
Member

@BrandonHBodine BrandonHBodine commented Feb 6, 2025

What this does:
This PR adds a DRF Patch endpoint for updating the "provider" field on VideoTranscript records.

Context:
When 2u/Edx wanted to add ai-translated content to the platform part of the project was translating the video transcripts. During the creation of the translated transcripts they were labeled with the provider="Custom" which has turned out to be too broad for some of the use cases Edx is looking to build out. We have since added a new provider in this repo and are looking to apply it with this change.

The status of the translated transcripts live in an external service (IDA in edx terms) and needs access to edx-val via the REST interface which is the core reason behind this change.

This is in regards to the following 2U ticket.
https://2u-internal.atlassian.net/browse/AU-2381

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.65%. Comparing base (b7c5db6) to head (d98e62e).

Files with missing lines Patch % Lines
edxval/views.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   94.58%   94.65%   +0.06%     
==========================================
  Files          32       32              
  Lines        3178     3256      +78     
  Branches      122      126       +4     
==========================================
+ Hits         3006     3082      +76     
- Misses        154      156       +2     
  Partials       18       18              
Flag Coverage Δ
unittests 94.65% <97.46%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hajorg hajorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment but LGTM otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants