ISSUE #50 - Added autoplay configuration #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brummbar
requested changes
Mar 23, 2020
| /** | ||
| * The default autoplay setting. | ||
| */ | ||
| public const DEFAULT_AUTOPLAY = 1; |
There was a problem hiding this comment.
We can skip this constant, it's enough to use a boolean.
| @@ -126,6 +131,7 @@ public static function defaultSettings(): array { | |||
| return [ | |||
| 'max_width' => self::DEFAULT_WIDTH, | |||
| 'max_height' => self::DEFAULT_HEIGHT, | |||
| 'autoplay_setting' => self::DEFAULT_AUTOPLAY, | |||
There was a problem hiding this comment.
Let's just use
Suggested change
| 'autoplay_setting' => self::DEFAULT_AUTOPLAY, | |
| 'autoplay' => TRUE, |
| @@ -234,6 +246,7 @@ public function viewElements(FieldItemListInterface $items, $langcode): array { | |||
| protected function viewElement(FieldItemInterface $item): array { | |||
| $max_width = $this->getSetting('max_width'); | |||
| $max_height = $this->getSetting('max_height'); | |||
| $autoplay_setting = $this->getSetting('autoplay_setting') == 0 ? FALSE : TRUE; | |||
There was a problem hiding this comment.
The setting is a boolean, why we compare it with 0?
There was a problem hiding this comment.
I see below that autoplay was passed as string true, maybe we should convert to strings true/false?
| @@ -155,6 +161,12 @@ public function settingsForm(array $form, FormStateInterface $form_state): array | |||
| '#min' => 0, | |||
| ]; | |||
|
|
|||
| $form['autoplay_setting'] = [ | |||
| '#type' => 'checkbox', | |||
| '#title' => $this->t('Autoplay enabled'), | |||
There was a problem hiding this comment.
Suggested change
| '#title' => $this->t('Autoplay enabled'), | |
| '#title' => $this->t('Autoplay'), |
should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
Autoplay setting has been added in FieldFormatter
Change log
Autoplay setting