Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused private method #1991

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Remove unused private method #1991

merged 3 commits into from
Jan 7, 2025

Conversation

mattwthompson
Copy link
Member

This method is not called in any tests, not called by any other methods, and it not used by any downstream code (nor should it be).

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (c303f30) to head (4b786e3).
Report is 3 commits behind head on main.

Additional details and impacted files

j-wags
j-wags approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattwthompson!

@j-wags j-wags merged commit 275dd79 into main Jan 7, 2025
15 of 16 checks passed
@j-wags j-wags deleted the remove-unused-code branch January 7, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags