Consolidate Python config files #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
force-pushed
the
consolidate-configs
branch
from
fb7c06f to
dbe249c
Compare
1 task
Closed
j-wags
approved these changes
Jan 16, 2025
openff/utilities/testing.py
Outdated
Comment on lines
46
to
52
| raise ValueError("Bad type passed to skip_if_missing_exec. " f"Found type {type(exec)}") | ||
|
|
||
| found_exec = False | ||
| for exec_ in execs: | ||
| found_exec = found_exec or has_executable(exec_) | ||
|
|
||
| reason = f"Package {str(exec)} is required, but was not found." | ||
| reason = f"Package {exec!s} is required, but was not found." |
There was a problem hiding this comment.
(not blocking) both of these seem weird/worse to me. Maybe a weird interaction with a formatting tool? Not blocking either way, just stood out.
There was a problem hiding this comment.
It's probably an unnecessary cast tbh, but it's not going to be called at scale so the runtime penalty is small. I'm going to leave it as-is until it presents an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pyproject.tomlversioningitruffpixisupport doesn't interact in surprising waysStatus