-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(meta): show image preview #1046
Open
seaerchin
wants to merge
15
commits into
main
Choose a base branch
from
fix/meta-image-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+98
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab59be6
to
ad3c89d
Compare
Datadog ReportBranch report: ✅ 0 Failed, 266 Passed, 36 Skipped, 46.05s Total Time |
aa790c5
to
af08846
Compare
af08846
to
64e5b19
Compare
harishv7
reviewed
Jan 27, 2025
Base automatically changed from
chin/isom-1694-refactor-image-uploading
to
main
January 31, 2025 05:06
harishv7
reviewed
Jan 31, 2025
harishv7
reviewed
Jan 31, 2025
64b6b1b
to
1b4bdfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now on studio, we don't show the meta image on upload. this PR implements a simple preview for meta image.
Solution
meta
format inside our components. this is required because we use json forms to render our meta settings but we don't have a previewmeta
renderer that uses the retry strategy in the base branch. we render the preview right below (pending design comments omegalul)Video
Screen.Recording.2025-01-27.at.1.20.52.PM.mov
Tests