Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): show image preview #1046

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix(meta): show image preview #1046

wants to merge 15 commits into from

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Jan 27, 2025

Problem

Right now on studio, we don't show the meta image on upload. this PR implements a simple preview for meta image.

Solution

  1. add a meta format inside our components. this is required because we use json forms to render our meta settings but we don't have a preview
  2. in our renderers, add a meta renderer that uses the retry strategy in the base branch. we render the preview right below (pending design comments omegalul)

Video

Screen.Recording.2025-01-27.at.1.20.52.PM.mov

Tests

  1. create a page
  2. go to the meta settings
  3. upload an image
  4. the image should render after a while
  5. delete the image
  6. upload another image
  7. the new image should render

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 27, 2025

Datadog Report

Branch report: fix/meta-image-preview
Commit report: ad455a9
Test service: isomer-studio

✅ 0 Failed, 266 Passed, 36 Skipped, 46.05s Total Time
➡️ Test Sessions change in coverage: 1 no change

@seaerchin seaerchin requested review from harishv7 and a team January 27, 2025 08:03
Base automatically changed from chin/isom-1694-refactor-image-uploading to main January 31, 2025 05:06
package-lock.json Outdated Show resolved Hide resolved
@seaerchin seaerchin requested review from harishv7 and a team January 31, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants