Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base architecture with .docx support #19

Merged
merged 49 commits into from
May 13, 2024
Merged

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Apr 14, 2024

Reference Issues/PRs

#1 #2 #3 #4 #5 #6 #7 #10 #14 #18 #22

What does this implement/fix? Explain your changes.

base architecture with .docx support + a huge refactoring in the template file.

  • clear functionality
  • clear all functionality
  • update functionality
  • update all functionality

Any other comments?

AHReccese and others added 11 commits January 12, 2024 20:56
update metadoc project's description
Bumps [numpy](https://github.com/numpy/numpy) from 1.26.2 to 1.26.3.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.26.2...v1.26.3)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [scikit-learn](https://github.com/scikit-learn/scikit-learn) from 1.3.2 to 1.4.0.
- [Release notes](https://github.com/scikit-learn/scikit-learn/releases)
- [Commits](scikit-learn/scikit-learn@1.3.2...1.4.0)

---
updated-dependencies:
- dependency-name: scikit-learn
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [numpy](https://github.com/numpy/numpy) from 1.26.3 to 1.26.4.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.26.3...v1.26.4)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AHReccese AHReccese added this to the MetaDoc v0.1 milestone Apr 14, 2024
@AHReccese AHReccese self-assigned this Apr 14, 2024
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your efforts 🔥
Please take a look at my comments 🥇

setup.py Outdated Show resolved Hide resolved
dmeta/util.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from sepandhaghighi May 1, 2024 10:21
@AHReccese
Copy link
Member Author

All of the requested changes have been applied accordingly.
Let me know if you have any other.
@sepandhaghighi

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your efforts 💯
I suggest using DMeta instead of dmeta in titles (I mentioned some of them in the code).

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
dmeta/functions.py Outdated Show resolved Hide resolved
dmeta/params.py Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from sepandhaghighi May 2, 2024 15:46
@AHReccese
Copy link
Member Author

AHReccese commented May 2, 2024

I tried to update dmeta to DMeta in every place I found. please let me know if there are any others.
@sepandhaghighi

@AHReccese
Copy link
Member Author

@sepandhaghighi
Dear Sepand please forget the CI/CD failure in this PR and finalize your review.
I will push up a separate Test & CI/CD dedicated PR after that.

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese

I believe it would be better to use the defusedxml package for XML parsing. The default XML package has lots of known and unknown vulnerabilities.
As this change will result in significant changes, I suggest handling it in a separate PR.

@sepandhaghighi sepandhaghighi merged commit 4ce9039 into dev May 13, 2024
36 of 42 checks passed
@sepandhaghighi sepandhaghighi deleted the feature/base_architecture branch May 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants