Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #24

Merged
merged 18 commits into from
May 22, 2024
Merged

Tests #24

merged 18 commits into from
May 22, 2024

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented May 21, 2024 •
edited
Loading

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added the test label May 21, 2024
@AHReccese AHReccese added this to the MetaDoc v0.1 milestone May 21, 2024
@AHReccese AHReccese self-assigned this May 21, 2024
@AHReccese AHReccese requested a review from sepandhaghighi May 21, 2024 06:21
@AHReccese AHReccese marked this pull request as ready for review May 21, 2024 06:21
@AHReccese
Copy link
Member Author

Dmeta tests can get stricter, I mean we can get before and after personal tags and compare them, in the case of clear the after one should be "" and in the case of update it should be the updated parameter, but since functions don't raise any exception it is pretty obvious that it ran successfully. I know technically we shouldn't rely on this but I just wanted to see whether you think it is critical to fulfill it right now or we may postpone it to a later time maybe?
@sepandhaghighi

If you think we shouldn't, please review the PR so far and I will fulfill the tests.
Thanks

sepandhaghighi
sepandhaghighi approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@sepandhaghighi sepandhaghighi merged commit 2401bf0 into dev May 22, 2024
42 checks passed
@sepandhaghighi sepandhaghighi deleted the tests branch May 22, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@AHReccese AHReccese

Labels
test
Projects
None yet
Milestone
DMeta v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AHReccese @sepandhaghighi