SDMXCode to read parent codes properly #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a bug where the parent code ids where not reachable.
parentCode fetching from parentNode if it exists
eblondel
approved these changes
Jan 8, 2025
|
Thanks, merging now. Do you agree if I add you as contrib in package DESCRIPTION? Thanks |
|
Sure thing Emmanuel. And thank you! PS should I be worried about the one failing check? Do you want me to look into it? |
|
@gvdr i've triggered again the tests, sounds that the errors were dealing with some service data providers, not your code. Let's see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #214.
You can find here a small fix to
SDMXCode-methods.Rto parse a parent code's id when they are presented in a nested node of the target code.Also in the PR an example of a hierarchical codelist, and relevant test that fails on main version of {rsdmx} and succeeds in this branch.