-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-43812: k8s bump to 1.30.1 #425
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Moebasim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Moebasim: This pull request references Jira Issue OCPBUGS-48071, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@Moebasim: This pull request references Jira Issue OCPBUGS-48071, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/hold |
Dockerfile
Outdated
@@ -32,4 +32,4 @@ RUN ln -s /usr/bin/openshift-builder /usr/bin/openshift-sti-build && \ | |||
LABEL io.k8s.display-name="OpenShift Builder" \ | |||
io.k8s.description="This is a component of OpenShift and is responsible for executing image builds." \ | |||
io.openshift.tags="openshift,builder" | |||
ENTRYPOINT [ "/usr/bin/entrypoint.sh" ] | |||
ENTRYPOINT [ "/usr/bin/entrypoint.sh" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this - I don't think it is needed, and it will create a merge conflict with #414
go 1.22.0 | ||
|
||
toolchain go1.22.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require an update to ci-operator.yaml - it needs a go 1.22-based builder image (at minimum).
Please also check with the ART team (#forum-ocp-art) that it is OK to add toolchain
directives to the go.mod
file.
@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1d22977
to
7a80d6a
Compare
4a81ac0
to
3c773d1
Compare
3c773d1
to
dd00cf4
Compare
@Moebasim: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Moebasim: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Upgraded Kubernetes dependency from 1.28.2 to 1.30.1
This update upgrades the Kubernetes dependency from 1.28.2 to 1.30.1 to close the version gap that appeared when OpenShift continued with Kubernetes v1.28.2 through version 4.16, even though Kubernetes had moved ahead. OpenShift 4.15 was the last version where OpenShift and Kubernetes were closely aligned. With OpenShift 4.18, Golang was also upgraded from v1.21 to v1.22 to ensure compatibility with the newer Kubernetes release.