Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43812: k8s bump to 1.30.1 #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Moebasim
Copy link

@Moebasim Moebasim commented Jan 7, 2025

Upgraded Kubernetes dependency from 1.28.2 to 1.30.1

This update upgrades the Kubernetes dependency from 1.28.2 to 1.30.1 to close the version gap that appeared when OpenShift continued with Kubernetes v1.28.2 through version 4.16, even though Kubernetes had moved ahead. OpenShift 4.15 was the last version where OpenShift and Kubernetes were closely aligned. With OpenShift 4.18, Golang was also upgraded from v1.21 to v1.22 to ensure compatibility with the newer Kubernetes release.

@openshift-ci openshift-ci bot requested review from divyansh42 and prabhapa January 7, 2025 12:49
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Moebasim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@Moebasim Moebasim changed the title Upgraded Kubernetes dependency from 1.28.2 to 1.30.1 OCPBUGS-43812: Upgraded Kubernetes dependency from 1.28.2 to 1.30.1 Jan 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 7, 2025
@openshift-ci-robot
Copy link
Contributor

@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Upgraded Kubernetes dependency from 1.28.2 to 1.30.1

This update upgrades the Kubernetes dependency from 1.28.2 to 1.30.1 to close the version gap that appeared when OpenShift continued with Kubernetes v1.28.2 through version 4.16, even though Kubernetes had moved ahead. OpenShift 4.15 was the last version where OpenShift and Kubernetes were closely aligned. With OpenShift 4.18, Golang was also upgraded from v1.21 to v1.22 to ensure compatibility with the newer Kubernetes release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Moebasim Moebasim changed the title OCPBUGS-43812: Upgraded Kubernetes dependency from 1.28.2 to 1.30.1 OCPBUGS-48071: Upgraded Kubernetes dependency from 1.28.2 to 1.30.1 Jan 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 7, 2025
@openshift-ci-robot
Copy link
Contributor

@Moebasim: This pull request references Jira Issue OCPBUGS-48071, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Upgraded Kubernetes dependency from 1.28.2 to 1.30.1

This update upgrades the Kubernetes dependency from 1.28.2 to 1.30.1 to close the version gap that appeared when OpenShift continued with Kubernetes v1.28.2 through version 4.16, even though Kubernetes had moved ahead. OpenShift 4.15 was the last version where OpenShift and Kubernetes were closely aligned. With OpenShift 4.18, Golang was also upgraded from v1.21 to v1.22 to ensure compatibility with the newer Kubernetes release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Moebasim
Copy link
Author

Moebasim commented Jan 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Moebasim: This pull request references Jira Issue OCPBUGS-48071, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Moebasim
Copy link
Author

Moebasim commented Jan 7, 2025

/retest

@prabhapa
Copy link
Contributor

prabhapa commented Jan 7, 2025

/hold
till we make sure the main golang version bump and dockerfile base image versions etc are ok.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
Dockerfile Outdated
@@ -32,4 +32,4 @@ RUN ln -s /usr/bin/openshift-builder /usr/bin/openshift-sti-build && \
LABEL io.k8s.display-name="OpenShift Builder" \
io.k8s.description="This is a component of OpenShift and is responsible for executing image builds." \
io.openshift.tags="openshift,builder"
ENTRYPOINT [ "/usr/bin/entrypoint.sh" ]
ENTRYPOINT [ "/usr/bin/entrypoint.sh" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this - I don't think it is needed, and it will create a merge conflict with #414

Comment on lines +3 to +5
go 1.22.0

toolchain go1.22.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require an update to ci-operator.yaml - it needs a go 1.22-based builder image (at minimum).

Please also check with the ART team (#forum-ocp-art) that it is OK to add toolchain directives to the go.mod file.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@Moebasim Moebasim changed the title OCPBUGS-48071: Upgraded Kubernetes dependency from 1.28.2 to 1.30.1 OCPBUGS-43812: Upgraded Kubernetes dependency from 1.28.2 to 1.30.1 Jan 16, 2025
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 16, 2025
@openshift-ci-robot
Copy link
Contributor

@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Upgraded Kubernetes dependency from 1.28.2 to 1.30.1

This update upgrades the Kubernetes dependency from 1.28.2 to 1.30.1 to close the version gap that appeared when OpenShift continued with Kubernetes v1.28.2 through version 4.16, even though Kubernetes had moved ahead. OpenShift 4.15 was the last version where OpenShift and Kubernetes were closely aligned. With OpenShift 4.18, Golang was also upgraded from v1.21 to v1.22 to ensure compatibility with the newer Kubernetes release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Moebasim
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Moebasim
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 16, 2025
@openshift-ci-robot
Copy link
Contributor

@Moebasim: This pull request references Jira Issue OCPBUGS-43812, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2025
@Moebasim Moebasim force-pushed the OCPBUGS-43812 branch 2 times, most recently from 1d22977 to 7a80d6a Compare January 16, 2025 13:53
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2025
@Moebasim Moebasim force-pushed the OCPBUGS-43812 branch 2 times, most recently from 4a81ac0 to 3c773d1 Compare January 16, 2025 14:25
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2025
@Moebasim Moebasim changed the title OCPBUGS-43812: Upgraded Kubernetes dependency from 1.28.2 to 1.30.1 OCPBUGS-43812: k8s bump to 1.30.1 Jan 16, 2025
@openshift-cherrypick-robot

@Moebasim: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@Moebasim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security dd00cf4 link false /test security
ci/prow/okd-scos-e2e-aws-ovn dd00cf4 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-cgroupsv2 dd00cf4 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-builds-techpreview dd00cf4 link false /test e2e-aws-ovn-builds-techpreview
ci/prow/e2e-aws-ovn-image-ecosystem dd00cf4 link true /test e2e-aws-ovn-image-ecosystem
ci/prow/verify dd00cf4 link true /test verify
ci/prow/images dd00cf4 link true /test images
ci/prow/unit dd00cf4 link true /test unit
ci/prow/e2e-aws-ovn-builds dd00cf4 link true /test e2e-aws-ovn-builds
ci/prow/e2e-aws-ovn dd00cf4 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-proxy dd00cf4 link false /test e2e-aws-ovn-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants