Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-34544: UPSTREAM: <carry>: Disable PersistentVolumeLabel by default #1991

Merged

Conversation

jsafrane
Copy link

Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions.

The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30.

This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on too many places.

Remove PersistentVolumeLabel admission plugin from the default list of
enabled admissions.

The plugin is deprecated upstream and most of its functionality was removed
in 1.29 and 1.30.

This is continuation of openshift/cluster-kube-apiserver-operator#1693,
the admission is enabled on multiple places.
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 18, 2024
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-34544, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @chao007

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions.

The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30.

This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on too many places.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from chao007, deads2k and soltysh June 18, 2024 12:46
@jsafrane
Copy link
Author

/cherry-pick release-4.16
It is necessary for hypershift on Azure to fix https://issues.redhat.com//browse/OCPBUGS-34544 and its 4.16 clone.
It may be helpful in standalone OCP too.

@openshift-cherrypick-robot

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16
It is necessary for hypershift on Azure to fix https://issues.redhat.com//browse/OCPBUGS-34544 and its 4.16 clone.
It may be helpful in standalone OCP too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rphillips
Copy link

/lgtm

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jun 18, 2024
Copy link

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rphillips, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
Copy link

openshift-ci bot commented Jun 18, 2024

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7d2df9a into openshift:master Jun 18, 2024
19 checks passed
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-34544: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-34544 has not been moved to the MODIFIED state.

In response to this:

Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions.

The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30.

This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on too many places.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@jsafrane: new pull request created: #1993

In response to this:

/cherry-pick release-4.16
It is necessary for hypershift on Azure to fix https://issues.redhat.com//browse/OCPBUGS-34544 and its 4.16 clone.
It may be helpful in standalone OCP too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.17.0-202406181842.p0.g7d2df9a.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants