Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configobserver: drop observer for minimum kubelet version #1898

Merged
merged 1 commit into from
Dec 10, 2024
Merged

configobserver: drop observer for minimum kubelet version #1898

merged 1 commit into from
Dec 10, 2024

Conversation

haircommander
Copy link
Member

as it's being moved to cluster-kube-apiserver-operator for easier iteration

@haircommander
configobserver: drop observer for minimum kubelet version
3fce1be 
as it's being moved to cluster-kube-apiserver-operator for easier iteration

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot requested review from harche and sairameshv November 26, 2024 19:03
@haircommander haircommander mentioned this pull request Nov 26, 2024
Open
sairameshv
sairameshv approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@sairameshv sairameshv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
p0lyn0mial
p0lyn0mial reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@p0lyn0mial p0lyn0mial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be moved to openshift/cluster-kube-apiserver-operator#1754

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, p0lyn0mial, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 75da18e into openshift:master Dec 10, 2024
4 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@haircommander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@sairameshv sairameshv sairameshv approved these changes

@harche harche Awaiting requested review from harche

Assignees

@sairameshv sairameshv

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haircommander @sairameshv @p0lyn0mial