Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of redirect URI with --skip-provider-button #22

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

simo5
Copy link

@simo5 simo5 commented Oct 6, 2017

Cherry-pick bitly#395

Fixes #18

@simo5
Copy link
Author

simo5 commented Oct 6, 2017

@crobby @mrogers950 PTAL

@mrogers950
Copy link

Should this come with the additional logic as mentioned in bitly#395 (comment) ?

Copy link

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these changes with my app deployment against openshift 3.6 and it is working as expected.
Thanks

@simo5 simo5 merged commit 3c46c54 into openshift:master Oct 6, 2017
@jimmidyson
Copy link

Was just about to ask about this being merged from upstream - thanks! Any idea when this will be available in a Docker image, either on Docker Hub or productized?

@simo5
Copy link
Author

simo5 commented Oct 13, 2017

@jimmidyson unless it is critical I think we'll release after 3.7 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants