OCPBUGS-43478: generalize the RHEL8 and RHEL9 subscription_content.go test

[chandra0007]

No description provided.

[openshift-ci-robot]

@chandra0007: This pull request references Jira Issue OCPBUGS-43478, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[prb112]

small nits...
/lgtm

[prb112]

/retest-required

[openshift-trt]

Job Failure Risk Analysis for sha: 3ba811b

Job Name

Failure Risk

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6

Medium [sig-arch][Late] operators should not create watch channels very often [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel] This test has passed 87.04% of 54 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6'] in the last 14 days. Open Bugs Component Readiness: [Unknown] [Other] test regressed

[chandra0007]

/retest-required

[prb112]

e2e-gcp-ovn-builds is blocked by https://issues.redhat.com/browse/OCPBUGS-44257

[prb112]

based on a review, these changes make sense. I'll watch the verify job.

[prb112]

Hey @adambkaplan I hope you are well. We are updating the subscription_content.go tests to be multiarch. Could you review / approve or assign? Thanks, Paul

[prb112]

/retest

[openshift-trt]

Job Failure Risk Analysis for sha: 2149030

Job Name

Failure Risk

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade

High [sig-network] pods should successfully create sandboxes by pinging container registry This test has passed 100.00% of 154 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. --- [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-kube-controller-manager This test has passed 100.00% of 154 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

[adambkaplan]

For ubi 8 and 9, I believe the RHEL repositories use the following convention:

<package-repo>-($arch)-rpms

I think you are better off editing the YAML in test/extended/testdata/builds/subscription-content directly.

[prb112]

For ubi 8 and 9, I believe the RHEL repositories use the following convention:

<package-repo>-($arch)-rpms

I think you are better off editing the YAML in test/extended/testdata/builds/subscription-content directly.

Hey @adambkaplan

Are you suggesting we have multiple yamls? One for each arch?
We'd still need to flip the testdata selection based on the architecture.

If so, we'd happily make that change.

Thanks

Paul

[adambkaplan]

Quite the opposite - one YAML per RHEL version, but in-line the arch environment variable.

[prb112]

Quite the opposite - one YAML per RHEL version, but in-line the arch environment variable.

Got it! I'll chat with Chandra when he is back in office (tomorrow)

[openshift-trt]

Job Failure Risk Analysis for sha: 9b4bbee

Job Name	Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn	IncompleteTests Tests for this run (12) are below the historical average (2371): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout	Medium [bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info This test has passed 88.00% of 25 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-kube-apiserver-rollout' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-kube-apiserver-rollout'] in the last 14 days. Open Bugs alert/KubeAPIErrorBudgetBurn should not be at or above info

[prb112]

Thanks Chandra, this looks good, let's watch the job results.

[prb112]

/retest

[prb112]

/retest-required

[prb112]

/retest-required

[openshift-trt]

Job Failure Risk Analysis for sha: 074e750

Job Name	Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn	IncompleteTests Tests for this run (20) are below the historical average (1329): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial	IncompleteTests Tests for this run (22) are below the historical average (305): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-microshift	IncompleteTests Tests for this run (22) are below the historical average (669): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout	Low [Conformance][Suite:openshift/kube-apiserver/rollout][Jira:"kube-apiserver"][sig-kube-apiserver] kube-apiserver should roll out new revisions without disruption [apigroup:config.openshift.io][apigroup:operator.openshift.io] This test has passed 61.54% of 13 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-kube-apiserver-rollout'] in the last 14 days.

[prb112]

Hey @adambkaplan

We analyzed the logs and find this PR is ready for LGTM and further review. The only failure we see is known: The PR #29355 and bug https://issues.redhat.com/browse/OCPBUGS-44257

[sig-builds][Feature:Builds][Slow] s2i build with environment file in sources Building from a template should create a image from "test-env-build.json" template and run it in a pod [apigroup:build.openshift.io][apigroup:image.openshift.io]

Thanks,

Paul

[adambkaplan]

Realized that what we need is the output from the arch command to get the right RPM repo.

As a bonus, much of the changes in subscription_content.go can be reverted here.

[prb112]

/lgtm
Thanks Chandra

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chandra0007, prb112
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-trt]

Job Failure Risk Analysis for sha: 00ad317

Job Name	Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn	IncompleteTests Tests for this run (20) are below the historical average (1050): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

[openshift-ci]

New changes are detected. LGTM label has been removed.

[prb112]

/retest

[prb112]

/retest-required

[prb112]

/retest

[openshift-trt]

Job Failure Risk Analysis for sha: 6339c97

Job Name

Failure Risk

pull-ci-openshift-origin-master-e2e-aws-ovn-serial

Medium [sig-network][Feature:EgressIP][apigroup:operator.openshift.io] [external-targets][apigroup:user.openshift.io][apigroup:security.openshift.io] pods should keep the assigned EgressIPs when being rescheduled to another node [Serial] [Suite:openshift/conformance/serial] This test has passed 96.74% of 92 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-serial] in the last 14 days.

[prb112]

/retest

[openshift-ci]

@chandra0007: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[prb112]

Hey @adambkaplan I think this is ready for your re-review. Thanks, Paul