Process boarding location for OSM ways (linear platforms)

[miklcct]

Summary

This adds the processing of boarding locations on linear platforms.

Fixes #6056

Unit tests

added

Documentation

None

Bumping the serialization version id

No longer needed

[leonardehrenfried]

We talked about this today and we came to the conclusion that we want to introduce a data structure that is available during graph build only and then discarded. Lets discuss this in a meeting.

[miklcct]

Does moving the LinearPlatform field into StreetEdge and marking it as transient achieve the above, and avoid a serialisation bump?

[leonardehrenfried]

Unfortuntately not. We want to design a new system for keeping information that is used during graph build only and then discarded.

[codecov]

Codecov Report

Attention: Patch coverage is 86.77686% with 16 lines in your changes missing coverage. Please review.

Project coverage is 69.84%. Comparing base (0fb152d) to head (35f8b5d).
Report is 73 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...aph_builder/module/OsmBoardingLocationsModule.java	92.53%	2 Missing and 3 partials ⚠️
...rg/opentripplanner/graph_builder/GraphBuilder.java	0.00%	3 Missing ⚠️
...ner/standalone/configure/ConstructApplication.java	0.00%	3 Missing ⚠️
..._builder/module/configure/GraphBuilderModules.java	0.00%	1 Missing ⚠️
...o/internal/DefaultOsmInfoGraphBuildRepository.java	87.50%	1 Missing ⚠️
...info/internal/DefaultOsmInfoGraphBuildService.java	80.00%	1 Missing ⚠️
...n/java/org/opentripplanner/standalone/OTPMain.java	0.00%	1 Missing ⚠️
...pplanner/standalone/configure/LoadApplication.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6247      +/-   ##
=============================================
+ Coverage      69.79%   69.84%   +0.05%     
- Complexity     17943    17976      +33     
=============================================
  Files           2046     2049       +3     
  Lines          76685    76756      +71     
  Branches        7829     7832       +3     
=============================================
+ Hits           53520    53608      +88     
+ Misses         20423    20412      -11     
+ Partials        2742     2736       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[habrahamsson-skanetrafiken]

@t2gran will come with some suggestions of how to solve this without adding anything to the serialized graph.

[t2gran]

There is one thing I do not understand here. Is it true that in the OSM model the boarding reference can be on both way and node, and that it is only on Vertex in OTP? If so, why are we not just coping the boarding references to the vertexes it is connected to?

I think the correct behavior for the routing would be to "arrive at the stop" when you arrive at one of the vertexes included in the platform.

[miklcct]

I think your behaviour is correct but it isn't supported even for the area platforms yet. The centroid is currently calculated and used.

Maybe I should try to connect the stop to every vertexes instead (and also do it for area platforms as well)

[t2gran]

I am almost done with storing the refs between builders, so I will publish that here when I am done. Lets, discuss this on Tuesday again. I would like some feedback from the "AStar experts" on how to NOT model a stop as a point? This is likely to be a bigger refactoring, but for some stops modeling it as a point is problematic.

[t2gran]

Here is how you can excange data between builders - the data is persserved during serialization:

3825a02

[vesameskanen]

Code looks good to me. I wonder if linking the platform centroid to all edges of a linear platform would be a more straightforward solution; now the code links the centroid with a subset of close enough edges. This not a problem, though, just a bit more complexity.

I agree on what Leonard stated about splitting the node-way-area linking to 3 separate functions.

[leonardehrenfried]

Looks good now, thanks!

[vesameskanen]

This is quite useful functionality! I will next make some fixes to area boarding location linking.