Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency org.entur:siri-java-model to v2 #6377

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.entur:siri-java-model 1.28 -> 2.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

entur/siri-java-model (org.entur:siri-java-model)

v2.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner January 10, 2025 13:01
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.82%. Comparing base (2134bf3) to head (2897ff3).
Report is 14 commits behind head on dev-2.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6377      +/-   ##
=============================================
- Coverage      69.82%   69.82%   -0.01%     
  Complexity     18143    18143              
=============================================
  Files           2072     2072              
  Lines          77323    77323              
  Branches        7841     7841              
=============================================
- Hits           53992    53991       -1     
- Misses         20580    20581       +1     
  Partials        2751     2751              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes support for SIRI 1, which we don't use, and adds an enum value to SIRI 2.1.

@vpaturet
Copy link
Contributor

I will test this with Norwegian SIRI data.

@vpaturet
Copy link
Contributor

This seems to break backward compatibility.
We investigate this issue further.

13:52:45.232 INFO [updater-0]  (GooglePubsubEstimatedTimetableSource.java:271) Fetching initial data - finished after 11484 ms, got 55.3 MB
Exception in thread "updater-0" java.lang.NoSuchMethodError: 'void uk.org.siri.www.siri.SiriType.makeExtensionsImmutable()'
	at uk.org.siri.www.siri.SiriType.<init>(SiriType.java:507)
	at uk.org.siri.www.siri.SiriType.<init>(SiriType.java:13)
	at uk.org.siri.www.siri.SiriType$1.parsePartialFrom(SiriType.java:8120)
	at uk.org.siri.www.siri.SiriType$1.parsePartialFrom(SiriType.java:8114)
	at com.google.protobuf.AbstractParser.parsePartialFrom(AbstractParser.java:77)
	at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:97)
	at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:102)
	at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:25)
	at uk.org.siri.www.siri.SiriType.parseFrom(SiriType.java:2260)
	at org.opentripplanner.updater.siri.updater.google.GooglePubsubEstimatedTimetableSource.serviceDelivery(GooglePubsubEstimatedTimetableSource.java:253)
	at org.opentripplanner.updater.siri.updater.google.GooglePubsubEstimatedTimetableSource.initializeData(GooglePubsubEstimatedTimetableSource.java:276)
	at org.opentripplanner.framework.retry.OtpRetry.execute(OtpRetry.java:48)
	at org.opentripplanner.updater.siri.updater.google.GooglePubsubEstimatedTimetableSource.start(GooglePubsubEstimatedTimetableSource.java:159)
	at org.opentripplanner.updater.siri.updater.google.SiriETGooglePubsubUpdater.run(SiriETGooglePubsubUpdater.java:64)
	at org.opentripplanner.updater.GraphUpdaterManager.lambda$startUpdaters$0(GraphUpdaterManager.java:100)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

@vpaturet
Copy link
Contributor

The regression does not come from this upgrade, but from #6342
See #6404

@t2gran t2gran added this to the 2.7 (next release) milestone Jan 29, 2025
@renovate renovate bot changed the title fix(deps): update dependency org.entur:siri-java-model to v2 Update dependency org.entur:siri-java-model to v2 Feb 3, 2025
@renovate renovate bot changed the title Update dependency org.entur:siri-java-model to v2 fix(deps): update dependency org.entur:siri-java-model to v2 Feb 6, 2025
@renovate renovate bot force-pushed the renovate/major-siri-java-model.version branch from e7f8711 to 2897ff3 Compare February 7, 2025 09:57
@leonardehrenfried leonardehrenfried merged commit b23c2e8 into dev-2.x Feb 7, 2025
6 checks passed
@leonardehrenfried leonardehrenfried deleted the renovate/major-siri-java-model.version branch February 7, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants