Extract mapper for Transmodel bookWhen, new values for relativeDirection

[leonardehrenfried]

bookWhen

@t2gran had to fix a bug I introduced in #6385 which I feel a bit bad about. In order for this to not repeat itself I extracted a mapper for the field in question and added lots and lots of tests.

The line coverage in the mapper is 100% and the branch coverage 93%.

New enum values for Transmodel's relativeDirection

In #6343 we introduced a new internal enum value for RelativeDirection. We don't want to expose the type ever in the API so I introduced mapper to get rid of it. In that process I noticed that there are unmapped enum values in the Transmodel API, which I also mapped away.

@t2gran has requested that instead we add the enum values to the API which I did.

There was already a test for the enum serialisation which also tests the new values.

Issue

Relates to #6384

Unit tests

Added.

Documentation

Javadoc.

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.76%. Comparing base (1030408) to head (5639c31).

Files with missing lines	Patch %	Lines
...ner/apis/transmodel/mapping/BookingInfoMapper.java	88.88%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6393      +/-   ##
=============================================
+ Coverage      69.73%   69.76%   +0.02%     
- Complexity     18024    18034      +10     
=============================================
  Files           2057     2058       +1     
  Lines          76970    76973       +3     
  Branches        7846     7845       -1     
=============================================
+ Hits           53678    53697      +19     
+ Misses         20545    20528      -17     
- Partials        2747     2748       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[t2gran]

Thank you for fixing this.