-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix processing of one-way boarding locations #6410
Open
leonardehrenfried
wants to merge
10
commits into
opentripplanner:dev-2.x
Choose a base branch
from
leonardehrenfried:platform-fix
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix processing of one-way boarding locations #6410
leonardehrenfried
wants to merge
10
commits into
opentripplanner:dev-2.x
from
leonardehrenfried:platform-fix
+391
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6410 +/- ##
=============================================
+ Coverage 69.79% 69.84% +0.05%
- Complexity 18092 18129 +37
=============================================
Files 2064 2069 +5
Lines 77209 77271 +62
Branches 7859 7856 -3
=============================================
+ Hits 53888 53972 +84
+ Misses 20566 20544 -22
Partials 2755 2755 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
Introduce module tests for
Fix processing of one-way boarding locations
Jan 30, 2025
OsmModule
, fix graph build crash
abyrd
previously approved these changes
Jan 30, 2025
vesameskanen
requested changes
Jan 31, 2025
application/src/main/java/org/opentripplanner/osm/model/OsmWithTags.java
Outdated
Show resolved
Hide resolved
.../java/org/opentripplanner/graph_builder/module/osm/moduletests/_support/TestOsmProvider.java
Outdated
Show resolved
Hide resolved
vesameskanen
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It fixes a problem where invalid OSM platform data would crash the graph build.
In order to have more precise tests that only test individual OSM ways rather than a whole area, I extracted an interface for
OsmProvider
and added a test implementation. This makes it much easier to write tests that don't need to load OSM data from disk.Issue
Closes #6387
Closes #6388
Unit tests
Lots added.
Documentation
Javadoc.