Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so novacomd works with new libusb-compat #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jdieter
Copy link

@jdieter jdieter commented Apr 2, 2012

Use usb-bulk-[read|write] instead of homemade handlers. This allows us to
run against libusb-compat as well as the old libusb.

Signed-off-by: Jonathan Dieter [email protected]

Jonathan Dieter added 3 commits April 2, 2012 14:35
…s to

run against libusb-compat as well as the old libusb.

Signed-off-by: Jonathan Dieter <[email protected]>
Signed-off-by: Jonathan Dieter <[email protected]>
@ghost ghost assigned rajmani Apr 3, 2012
@rrix
Copy link

rrix commented Apr 19, 2012

I just tested this with libusb-compat on Fedora, works great. Thanks for being awesome, Jonathon :)

@jdieter
Copy link
Author

jdieter commented Apr 19, 2012

Thanks, I'm getting this reviewed for Fedora at https://bugzilla.redhat.com/show_bug.cgi?id=809114 and https://bugzilla.redhat.com/show_bug.cgi?id=809116.

@rrix
Copy link

rrix commented Apr 19, 2012

Is Mohamed still actively reviewing those packages? I'd love to help you get them in to fedora (I'm sponsored, as well, and was testing your patches to build an RPM locally ;) )

@jdieter
Copy link
Author

jdieter commented May 9, 2012

Sorry for the delay, but, yes, Mohamed finished reviewing the packages and novacom and novacomd are both available in the Fedora and EPEL repositories (currently updates-testing for F15+ and EL5+).

To install both (the common use-case), just install novacom using yum.

@rrix
Copy link

rrix commented May 10, 2012

That's awesome. Now if only @openwebos would review your patches :(

@SteveWinston
Copy link
Member

Hang in there guys - we're getting ready to start pulling in changes. We appreciate your patience!

@ghost ghost assigned kdopen Jun 23, 2012
@kdopen
Copy link

kdopen commented Sep 6, 2012

jonathon,

If you would like us to consider integrating this pull request, could I ask you to please add a DCO to our commit message and resubmit.

See https://github.com/openwebos/build-desktop/wiki/How%20we%20accept%20contributions and the pages it links to for instructions.

Congratulations, by the way, it looks like your changes got into Fedora, or am I misreading the bug reports you link to?

@joshgillies
Copy link

Any update on getting these merged?

@ericblade-owo
Copy link

The original submitter needs to send it up with the DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants