luci-base: fix createChoiceElement regex to catch closing tags with !

Signed-off-by: Paul Donald <[email protected]>
openwrt · Jan 11, 2025 · 2520588 · 2520588
1 parent abaa26a
commit 2520588
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/modules/luci-base/htdocs/luci-static/resources/ui.js b/modules/luci-base/htdocs/luci-static/resources/ui.js
@@ -1598,7 +1598,7 @@ const UIDropdown = UIElement.extend(/** @lends LuCI.ui.Dropdown.prototype */ {
 		let markup = null;
 
 		if (tpl)
-			markup = (tpl.textContent ?? tpl.innerHTML ?? tpl.firstChild.data).replace(/^<!--|-->$/, '').trim();
+			markup = (tpl.textContent ?? tpl.innerHTML ?? tpl.firstChild.data).replace(/^<!--|--!?>$/g, '').trim();
 		else
 			markup = '<li data-value="{{value}}"><span data-label-placeholder="true" /></li>';