Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-status: consider family when rendering nftables chains and rules #7566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skleeschulte
Copy link

In nftables, there can be multiple tables with the same name but different family attribute (inet, ip, ip6, ...). The same goes for chains. So the family attribute needs to be considered when rendering chains and rules.

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • Description: (describe the changes proposed in this PR)

Not sure which/how to increment package version, and not sure how to test.

@jow-

There can be multiple tables with the same name but different family attribute (inet, ip, ip6, ...). The same goes for chains. So the family attribute needs to be considered when rendering chains and rules.

Signed-off-by: Stefan Kleeschulte <[email protected]>
@systemcrash
Copy link
Contributor

Can you illustrate a before and after effect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants