✨ Bump rukpak to 0.17.0 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshaprasad96
commented
Jan 22, 2024
varshaprasad96
force-pushed
the
bump/rukpak-0.17.0
branch
from
746e7b2 to
a1ce4fb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 84.83% 84.53% -0.31%
==========================================
Files 20 20
Lines 930 931 +1
==========================================
- Hits 789 787 -2
- Misses 98 100 +2
- Partials 43 44 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
reviewed
Jan 22, 2024
This commit makes the following changes: 1. Bump Rukpak to use version 0.17.0 2. Modify the BundleDeployment spec accordingly to not specify a bundle template. 3. Introduce `watchNamespaces` field in the spec that accepts a list of namespaces to watch. 4. Fix unit and e2e tests accordingly. Signed-off-by: Varsha Prasad Narsing <[email protected]>
varshaprasad96
force-pushed
the
bump/rukpak-0.17.0
branch
from
a1ce4fb to
66ce118
Compare
varshaprasad96
requested review from
ncdc,
joelanford,
everettraven and
m1kola
m1kola
approved these changes
Jan 23, 2024
joelanford
approved these changes
Jan 23, 2024
Merged
via the queue into
operator-framework:main
with commit Jan 23, 2024
ef06f40
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes:
watchNamespacesfield in the spec that accepts a list of namespaces to watch.Description
Reviewer Checklist