Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding changelog and migrations for k8s 1.30 and kubebuilderv4 work #6862

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Nov 14, 2024

Description of the change:
Adding a change log and migration steps for all of the k8s and kubebuilder work for all the plugins.

Motivation for the change:
To have proper documentation.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@acornett21 acornett21 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@openshift-ci openshift-ci bot requested review from fabianvf and OchiengEd November 14, 2024 21:53
@acornett21
Copy link
Contributor Author

@Neo2308 This is what I have started so far. I'll try to get to the other plugins tomorrow.

@acornett21 acornett21 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@acornett21 acornett21 force-pushed the add_k8s_changelog branch 2 times, most recently from 08d311a to ecd50ba Compare November 18, 2024 17:37
@acornett21 acornett21 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acornett21

I added just a couple of nits about wording/text
Regarding the changes, it seems that you covered everything in the way we have been covering nowadays.

So, LGTM

@acornett21 acornett21 merged commit c6fef29 into operator-framework:master Nov 19, 2024
21 checks passed
@acornett21 acornett21 deleted the add_k8s_changelog branch November 19, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants